Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: FORMS-1476 use backup container v2.9.0 #1503

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

WalterMoar
Copy link
Collaborator

Description

In https://bcdevex.atlassian.net/browse/FORMS-887 most of the images were updated from 2.6.1 to 2.8.0. The production backup failed due to space issues, even though we have 7.8G of space for a 4G database that has 1.7G compressed backups.

Acceptance Criteria

  • Backups succeed
  • Backup verifications succeed
  • All backups and verifications run the same container version

Solution

Going through the version history of the backup container:

  • 2.6.1: where we started
  • 2.7.0: changed from gzip to tar; stop ignoring errors
  • 2.8.0: mongodb support
  • 2.8.1: reverted the gzip to tar change in v2.7.0
  • 2.9.0: postgresql 15 support

So the problem is that using tar took up too much space, but fixing it changed the way backups are stored and now that errors aren’t ignored the backup errors actually cause the verify to fail.

Will switch to v2.9.0 and use the -I flag to ignore errors when verifying the backups. This is not ideal but it is the way that v2.6.1 worked. Hopefully in the future the bug will get fixed and we can remove this flag.

Type of Change

build (change in build system or dependencies)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

Further comments

Follow bcgov/backup-container#132 to see when we can remove the -I flag.

The backup container has a bug where verifies will always fail. For now use the -I flag to ignore these failures. This was the behaviour of v2.6.1 and will have to do until the bug is fixed.
@WalterMoar WalterMoar marked this pull request as ready for review September 23, 2024 22:55
@WalterMoar WalterMoar merged commit 70c6915 into bcgov:main Sep 24, 2024
5 checks passed
@WalterMoar WalterMoar deleted the build/1476-backup-version branch September 24, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant